Skip to content

Added instructions on how to generate PEM keypair, needed by JWT authentication #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 4.6
Choose a base branch
from
Open

Added instructions on how to generate PEM keypair, needed by JWT authentication #2812

wants to merge 2 commits into from

Conversation

vidarl
Copy link
Contributor

@vidarl vidarl commented Jul 4, 2025

Question Answer
JIRA Ticket N/A
Versions 4.6
Edition Content/Headless, Experience, Commerce

The current instructions are incomplete, ref https://symfony.com/bundles/LexikJWTAuthenticationBundle/current/index.html#generate-the-ssl-keys

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025

Preview of modified files

Preview of modified Markdown:

@vidarl vidarl changed the title Added instructions on how to generate PEM generate keypair, needed by JWT authentication Added instructions on how to generate PEM keypair, needed by JWT authentication Jul 7, 2025
mnocon
mnocon reviewed Jul 9, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(please disregard, the review was sent too quickly)

mnocon
mnocon reviewed Jul 9, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions, thank you Vidar for creating this PR!

@vidarl
Copy link
Contributor Author

vidarl commented Jul 31, 2025

@mnocon : FYI, I am back from vacation and have finally approved your suggestions

@vidarl vidarl requested a review from mnocon July 31, 2025 10:05
@mnocon mnocon requested a review from a team July 31, 2025 11:12
@ezrobot ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team July 31, 2025 11:12
mnocon
mnocon approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Vidar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

@adriendupuis adriendupuis Awaiting requested review from adriendupuis

@dabrt dabrt Awaiting requested review from dabrt

@julitafalcondusza julitafalcondusza Awaiting requested review from julitafalcondusza

Assignees
No one assigned
Labels
Needs DOC review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vidarl @mnocon